Fixed OpenGLShader::PreProcess Logic (issue #120) #135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 'Pull Request: Implemented issue'
about: Fixes and explanatory comments for OpenGLShader::PreProcess
title: Fixed OpenGLShader::PreProcess logic (issue #120)
labels: ''
assignees: ''
PR impact (Make sure to add closing keywords)
List of related issues/PRs this will solve:
Proposed fix (Make sure you've read on how to contribute to Hazel)
We add two steps:
nextLinePos
is notstd::string::npos
.pos
isstd::string::npos
(if there is no next#type
token).We also add comments to clarify the purpose of each variable.
Additional context
This compiles and runs without error on the latest commit of Hazel.