Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FontAwesome to 4.6.1 #353

Closed
zhedar opened this issue Apr 25, 2016 · 5 comments
Closed

Update FontAwesome to 4.6.1 #353

zhedar opened this issue Apr 25, 2016 · 5 comments
Assignees
Milestone

Comments

@zhedar
Copy link
Collaborator

zhedar commented Apr 25, 2016

As FA 4.6.1 is available now, maybe we should update to that version with 0.8.2?

@stephanrauh stephanrauh added this to the v0.8.2 milestone Apr 25, 2016
@stephanrauh
Copy link
Collaborator

Doesn't sound risky to me, so you've got my "go!". Do you know what's changed since 4.6.0?

@zhedar
Copy link
Collaborator Author

zhedar commented Apr 25, 2016

We're currently running 4.5. Apparently 4.6 added 23 new icons, but something was wrong with 4.6, so 4.6.1 followed in an instant.

@zhedar
Copy link
Collaborator Author

zhedar commented Apr 27, 2016

I just found out how to upgrade the FA version we use and apparently, we only get it from CDN and don't bundle it locally. It wasn't in a property file, where I looked for it. I will include this small change in my current PR.
If we set the load from CDN context param to false and FA isn't included by another library (e.g. PrimeFaces) or by the user himself we won't load it at all, is that working as intended?

zhedar added a commit to zhedar/BootsFaces-OSP that referenced this issue Apr 27, 2016
zhedar added a commit to zhedar/BootsFaces-OSP that referenced this issue Apr 27, 2016
zhedar added a commit to zhedar/BootsFaces-OSP that referenced this issue Apr 28, 2016
@TheCoder4eu
Copy link
Owner

@zhedar can I close this issue?

@TheCoder4eu TheCoder4eu self-assigned this Apr 28, 2016
@zhedar
Copy link
Collaborator Author

zhedar commented Apr 28, 2016

It will get closed automatically, when #347 get's merged. So if you want to do that, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants