Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary dataTable summary info #518

Closed
MitchTalmadge opened this issue Oct 7, 2016 · 6 comments
Closed

Unnecessary dataTable summary info #518

MitchTalmadge opened this issue Oct 7, 2016 · 6 comments
Assignees
Milestone

Comments

@MitchTalmadge
Copy link
Contributor

This isn't urgent or anything, but I figured I'd bring it up. When disabling pagination on a b:dataTable, it still says "Showing x to y of x entries" at the bottom. Is this necessary? Example:

image

Wouldn't all the results be displayed all the time? I can't decide if it'd be best to leave or remove the text, so I'm just curious what others think.

@zhedar
Copy link
Collaborator

zhedar commented Nov 19, 2016

Agreed. We probably shouldn't show that, if no pagination is used. Maybe we should even make it a toggleable option to show the entrycount?

@zhedar
Copy link
Collaborator

zhedar commented Nov 19, 2016

As far as I saw there is no direct way in the JS api to do that. However, we could always hide the datatable_info element of the current datatable via css. Not the most elegant solution, but it may work.

@mtvweb
Copy link

mtvweb commented Dec 20, 2016

Option is available. Workaround: custom-options = "info:false"

@stephanrauh
Copy link
Collaborator

Thanks for giving us the hint, @mtvweb ! Now both the paginator and the info are hidden. I didn't implement an option to show the one while hiding the other. If someone needs that, a CSS statement will probably do the trick.

@stephanrauh stephanrauh self-assigned this Jan 17, 2017
@stephanrauh stephanrauh added this to the v1.1.0 milestone Jan 17, 2017
@mtvweb
Copy link

mtvweb commented Jan 18, 2017

This change breaks my project. :-(

I would prefer a separate option for the info to have more flexibility. My project uses a table with a limited range of lines to show them all without pagination, but I need the information about the contained lines.

Also I use some tables in forms, showing a few lines with pagination, but without information to decrease the amount of information in it. i.E. a table with a pageLength = 5, pagination = true, info = false. In this case it is enough to have a page indicator showing that there is another page with lines.

@stephanrauh
Copy link
Collaborator

After merging your PR #620, your project should be alive and kicking again :).

@TheCoder4eu TheCoder4eu moved this from TO DO to DONE in BootsFaces v1.1.0 Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants