Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b:radioButton required #648

Closed
chongma opened this issue Mar 2, 2017 · 4 comments
Closed

b:radioButton required #648

chongma opened this issue Mar 2, 2017 · 4 comments

Comments

@chongma
Copy link
Collaborator

chongma commented Mar 2, 2017

tried to use a b:radioButton instead of h:selectOneMenu in the

<b:radiobutton value="#{radiobuttonBean.favoriteColor}">
      <f:selectItem itemValue="Red"   itemLabel="Red it is!" />
      <f:selectItem itemValue="Green" itemLabel="I love green colors." />
      <f:selectItem itemValue="Blue"  itemLabel="What about blue?" />
  </b:radiobutton>

configuration but the b:radioButton lacks a required attribute or it is not working properly allowing empty submission

@stephanrauh
Copy link
Collaborator

It's a bit difficult to implement the required attribute with radio buttons because the radio buttons are only linked on the client. But maybe it's possible. Let us ponder about it.

@stephanrauh
Copy link
Collaborator

To my surprise, the required attribute already was supported, but a lot of corner cases didn't work yet. I've fixed that. BTW, I've also fixed AJAX along the way. For some reason unknown, it was broken.

image

image

@chongma
Copy link
Collaborator Author

chongma commented Mar 20, 2017

ok looks good. do you want me to verify testing? also when is v1.1.0 planned release?

@stephanrauh
Copy link
Collaborator

Tests are always appreciated. I'm afraid this feature might have several corner cases I didn't think of.

As for the 1.1.0: I guess it might become an Easter egg. If I'm not mistaken, @TheCoder4eu has started to prepare the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants