Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

b:progressBar value should be required #674

Closed
ggam opened this issue Apr 4, 2017 · 3 comments
Closed

b:progressBar value should be required #674

ggam opened this issue Apr 4, 2017 · 3 comments
Assignees
@stephanrauh
Labels
bug
Projects
BootsFaces v1.1.0
Milestone
v1.1.0

Comments

@ggam
Copy link
Collaborator

ggam commented Apr 4, 2017 •
edited

Using <b:progressBar /> without a value attribute throws a NullPointerException. The attribute should be marked required or a default value (like 0) applied.
stephanrauh added a commit that referenced this issue Apr 8, 2017
@stephanrauh
#674 the value of the progress bar now is mandatory. Plus, removed th…
040fb16 
…e immediate attribute from b:button because it doesn't support AJAX.
@stephanrauh
Copy link
Collaborator

stephanrauh commented Apr 8, 2017 •
edited

Is it sufficient to mark it "required" in the taglib? If so, the bug can be closed now.

@stephanrauh stephanrauh self-assigned this Apr 8, 2017
@stephanrauh stephanrauh added the bug label Apr 8, 2017
@stephanrauh stephanrauh added this to the v1.1.0 milestone Apr 8, 2017
@stephanrauh stephanrauh added this to DONE in BootsFaces v1.1.0 Apr 8, 2017
@ggam
Copy link
Collaborator Author

ggam commented Apr 8, 2017

Marking it as required on the taglib only serves to instruct IDEs AFAIK. The null pointer exception still happens. A FacesException explaining the problem would be more informative (apart from the required=true)

stephanrauh added a commit that referenced this issue Apr 8, 2017
@stephanrauh
#674 throw an useful exception if the value attribute is missing or null
d42e7b5
@stephanrauh
Copy link
Collaborator

OK!

@TheCoder4eu TheCoder4eu mentioned this issue Apr 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanrauh stephanrauh

Labels
bug
Projects
No open projects
BootsFaces v1.1.0
DONE
Milestone
v1.1.0
Development

No branches or pull requests
2 participants
@ggam @stephanrauh