Skip to content
This repository has been archived by the owner on Sep 26, 2022. It is now read-only.

feat(typing): adds more typescript definitions #11

Merged
merged 2 commits into from
Sep 26, 2020
Merged

feat(typing): adds more typescript definitions #11

merged 2 commits into from
Sep 26, 2020

Conversation

sbelzile-nexapp
Copy link
Contributor

The types I added to my project, if that can help you or somebody else :-)

Might be wrong on a few points (I don't use all of them so: to be reviewed).

@vercel
Copy link

vercel bot commented Sep 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/cm04qn2bf
✅ Preview: https://svelte-materialify-git-fork-sbelzile-nexapp-feature-typings.thecomputerm.vercel.app

@TheComputerM
Copy link
Owner

Hey, Thank you for your contribution. There are a few things that can be improved. I suspect that sveltejs/rfcs#37 will be approved so instead of directly importing SvelteComponent from svelte it is better to create a shared.d.ts that exports a class similar to the one in the RFC to make the transition smoother once the rfc is approved.

You can take a look at:

@TheComputerM TheComputerM added enhancement New feature or request good first issue Good for newcomers labels Sep 24, 2020
@sbelzile-nexapp
Copy link
Contributor Author

Did not know about this RFC: it's a good thing :-P. Anyway, I updated the code!

@TheComputerM
Copy link
Owner

Thank you very much, will merge this soon.

@TheComputerM TheComputerM merged commit d56a19a into TheComputerM:master Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants