Merge pull request #34 from TheDMSGroup/bug/precision-warning

Prevent warnings regarding 'precision'
TheDMSGroup · May 11, 2018 · 9469567 · 9469567
2 parents e8d716f + ac5267d
commit 9469567
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/Entity/EntityExtendedFieldsBuildFormTrait.php b/Entity/EntityExtendedFieldsBuildFormTrait.php
@@ -53,12 +53,6 @@ private function getFormExtendedFields(FormBuilderInterface $builder, array $opt
 
             switch ($type) {
                 case 'number':
-                    if (empty($properties['precision'])) {
-                        $properties['precision'] = null;
-                    } //ensure default locale is used
-                    else {
-                        $properties['precision'] = (int) $properties['precision'];
-                    }
 
                     if ('' === $value) {
                         // Prevent transform errors
@@ -76,7 +70,7 @@ private function getFormExtendedFields(FormBuilderInterface $builder, array $opt
                             'data'          => (null !== $value) ? (float) $value : $value,
                             'mapped'        => $mapped,
                             'constraints'   => $constraints,
-                            'precision'     => $properties['precision'],
+                            'precision'     => isset($properties['precision']) ? (int) $properties['precision'] : 0,
                             'rounding_mode' => isset($properties['roundmode']) ? (int) $properties['roundmode'] : 0,
                         ]
                     );

diff --git a/Form/UpdateLeadActionExtension.php b/Form/UpdateLeadActionExtension.php
@@ -119,12 +119,6 @@ private function getExtendedFormFields(FormBuilderInterface $builder, array $opt
 
             switch ($type) {
                 case 'number':
-                    if (empty($properties['precision'])) {
-                        $properties['precision'] = null;
-                    } //ensure default locale is used
-                    else {
-                        $properties['precision'] = (int) $properties['precision'];
-                    }
 
                     if ('' === $value) {
                         // Prevent transform errors
@@ -142,7 +136,7 @@ private function getExtendedFormFields(FormBuilderInterface $builder, array $opt
                             'data'          => (null !== $value) ? (float) $value : $value,
                             'mapped'        => $mapped,
                             'constraints'   => $constraints,
-                            'precision'     => $properties['precision'],
+                            'precision'     => isset($properties['precision']) ? (int) $properties['precision'] : 0,
                             'rounding_mode' => isset($properties['roundmode']) ? (int) $properties['roundmode'] : 0,
                         ]
                     );