Add llvm-sys linkage features #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDan64
reviewed
Jul 16, 2023
nohenry
force-pushed
the
llvm-sys-linkage-features
branch
from
1ea76a0
to
b486660
Compare
TheDan64
approved these changes
Jul 18, 2023
|
Not sure why CI is failing for version 16. Looks like this is a problem in other PRs as well. Building for 16 on my local machine works fine. |
|
Thanks! |
|
This is a nice feature as Arch linux and Gentoo do not ship static libs for llvm anymore. |
|
I can do so sometime this week but I'm really sick right now. Please feel free to ping me in a week if I forget |
|
@hamidrezakp fyi, inkwell 0.3.0 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added
force-dynamic,prefer-dynamic,force-static, andprefer-staticfeature flags to Cargo.toml for each version ofllvm-sysfrom 12-16 (these flags only became available in version 12).Related Issue
#427
How This Has Been Tested
cargo test --features llvm15-0-force-dynamicruns successfully. Also tested in a small project usingllvm15-0-force-dynamicenabled.