Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Map View and Incorporate Search Component #145

Closed
5 of 15 tasks
jkwening opened this issue Feb 20, 2018 · 2 comments
Closed
5 of 15 tasks

Enhance Map View and Incorporate Search Component #145

jkwening opened this issue Feb 20, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request frontend help wanted Extra attention is needed MVP Priority Priority issue needed for MVP Release Milestons

Comments

@jkwening
Copy link
Contributor

jkwening commented Feb 20, 2018

Build out map view per wireframe design: https://github.com/orgs/TheDevPath/teams/front-end-dev-team/discussions/1

MVP TODO:

  • Incorporate search component into map view
  • Style view
    • display: block
    • position: relative
    • stacked - nav bar, search, and then map view with map view taking majority of the screen space
    • play around with alternative style for nav bar: maybe links across the width (home, profile, favorites, sign-in)
  • Return search results (Next)
    • autocomplete and suggestions over top map view during search
    • scrollable search results either most screen with partial map or most of viewport with limited map in background
    • on selection focus map to location with marker
      • allow for options to get directions: to or from marker to/from current or provided location low-priority - MVP 2.0
      • if selection has google place id render/navigate a "places view" instead or as an option

MVP 2.0 Enhancements:

  • include saved pins as part of search query if regex matches
  • for authenticated users, preload saved pins on map
  • add multiple views for search results - with hidden defaulting to search history on select with no query entered
@jkwening jkwening self-assigned this Feb 20, 2018
@jkwening jkwening added this to To Do in Front End Development via automation Feb 20, 2018
@jkwening jkwening added help wanted Extra attention is needed next labels Feb 20, 2018
@jkwening jkwening removed their assignment Feb 20, 2018
@jkwening
Copy link
Contributor Author

Ready to hand off - I'm going to move onto getting a base directions view up and running next. See Todo list in first comment - this will require refactoring ./client/src/components/search/index.js:

  • no need to render map; remove any related references including user location - pass that through as a prop from the main Maps component that search component resides in. This should be passed through to MapContainer also. Actually this should be passed down from App component to all children that need it.
  • also it looks like the imported module is referencing a deprecated google api ? low-priority
  • if possible allow autocomplete; see an option for it but it looks like its turned off

@motosharpley motosharpley added this to Front End Tasks in Planning Board Feb 22, 2018
@jkwening jkwening self-assigned this Feb 24, 2018
@motosharpley motosharpley moved this from To Do to In progress in Front End Development Feb 25, 2018
This was referenced Feb 26, 2018
@jkwening jkwening added the MVP Priority Priority issue needed for MVP Release Milestons label Feb 26, 2018
@jkwening jkwening modified the milestones: MVP 2.0, Soft Launch MVP Feb 26, 2018
@jkwening
Copy link
Contributor Author

closing this ticket in favor of modular tasks:

@khusbuchandra hopefully this helps simplify what I was trying explain on slack.

Planning Board automation moved this from Front End Tasks to Complete Feb 28, 2018
Front End Development automation moved this from In progress to Done Feb 28, 2018
@jkwening jkwening removed the next label Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend help wanted Extra attention is needed MVP Priority Priority issue needed for MVP Release Milestons
Projects
Planning Board
  
Complete
Development

No branches or pull requests

2 participants