Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a default "simple" mode for material generation #263

Closed
TheDuckCow opened this issue Dec 24, 2021 · 4 comments
Closed

Create a default "simple" mode for material generation #263

TheDuckCow opened this issue Dec 24, 2021 · 4 comments
Labels
enhancement Feature requests or new functionality suggestions
Milestone

Comments

@TheDuckCow
Copy link
Member

At the moment, the default prep material shaders for Eevee and Cycles contain nodes that are relevant for only specular PBR packs, while the majority of users are using only default or simple Minecraft texturepacks which do not need all the extra features.

The consideration here is to make a simple shader that has pretty much just the bare minimum nodes connecting to a principled shader (for versions of blender where the principled shader is available).

Current ("Specular workflow"):
current

Proposed ("Simple non PBR"):
proposed

Note in the proposal, color is connected to emission, but emission is set to zero. It would be set to 1 for emissive materials. Note the displayed layout still has a separate transparent node: yes it would be simpler to use the alpha channel in the Principled node, however earlier versions of blender (which people still use) didn't have the alpha socket yet, so will need to see if I have time to implement the extra check against to see if the alpha socket is there to decide if we need to use a transparent shader node or not.

@TheDuckCow TheDuckCow added the enhancement Feature requests or new functionality suggestions label Dec 24, 2021
@TheDuckCow TheDuckCow added this to the v3.2.6 milestone Dec 24, 2021
@StandingPadAnimations
Copy link
Collaborator

Instead of using material nodes for emission, lamps may be a better option. It'll make it easier for EEVEE users, and Cycles users won't have to deal with as much noise

@TheDuckCow
Copy link
Member Author

Thanks for the comment! As per other chat, I think that will take a bit more time and consideration to implement, and can be moved into its own feature issue thread. Especially due to things like the limit of 128 lamps in an Eevee scene (a single 12x12 grid of glowstone would blow through that limit; how would it work for a lake of lava?). Adding lamps should probably be its own function/operator, though it could always be added back into prep materials as a tick box, similar to animate textures.

@StandingPadAnimations
Copy link
Collaborator

I think in areas where there's 2 or more faces with the same material, an area lamp could be used. If there's a single block on it's own, then one lamp per block. I'll also look into removing light sources that don't contribute much(like if they're a certain distance or behind the camera) in the optimizer

@TheDuckCow
Copy link
Member Author

Per comment mentioned issue above, it will be important that the simple material mode still includes the "add color overlay", since that will be critical to continue working with resource packs containing desaturated textures.

TheDuckCow added a commit that referenced this issue Dec 31, 2021
Some more testing would be ideal to ensure it is functioning and safe for general default usage, since the PBR flows are no longer the primary ones. Consider whether to change up to use specular by default and ease into using the new method. Resolves #263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or new functionality suggestions
Projects
None yet
Development

No branches or pull requests

2 participants