C++ OBJ importer #382
Merged
C++ OBJ importer #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roups for the C++ OBJ importer
When MCprep opens the file picker, both OBJs and MTLs can be selected, which was annoying when accidently selecting the MTL file of the OBJ. This adds a quality of life improvement by replacing .mtl with .obj if the user accidently clicks the MTL file
TheDuckCow
approved these changes
Mar 9, 2023
| res = None | ||
| if util.min_bv((3, 5)): | ||
| res = bpy.ops.wm.obj_import( | ||
| filepath=self.filepath, use_split_groups=True) |
There was a problem hiding this comment.
I think this diff hunk can be reverted. This "use_split_groups" works in 3.5 and equally in 3.4 and earlier, as written this would make 3.4 and earlier stop splitting out by objects from the source, which would not be good.
There was a problem hiding this comment.
Not sure what you mean, though I did catch the use of the wrong operator for 3.4 and below. In my testing, use_split_groups doesn't seem to work in 3.4 and below for the C++ importer
A mistake was made that made MCprep use the C++ OBJ importer in 3.4 and below, which is incorrect behavior.
|
Anyway, I'll merge this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for the C++ OBJ importer for Blender 3.5 and above