Generate jars as OSGi compliant bundles. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnlipp
added a commit
to mnlipp/jgrapes
that referenced
this pull request
Sep 28, 2022
Until (maybe) night-config becomes OSGi compliant (TheElectronWill/night-config#120).
|
Thanks for the PR! edit: In particular, I hope that it doesn't "bloat" the jars I publish on maven central. |
Just in case you are not familiar with OSGi, I recommend this, but I'm biased, obviously. |
mnlipp
added a commit
to mnlipp/jgrapes
that referenced
this pull request
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great library! I've just replaced a lot of my own code with it. The only problem (for me) is that OSGi support is lacking and I need the library in an OSGi environment. Adding OSGi information is quite easy. It requires upgrading gradle to at least 6.7, though, which didn't cause any problems.
It would be great if you could consider adding the support for OSGi.