Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HoconWriter to stop putting newlines at the head of the file #137

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

0x3C50
Copy link
Contributor

@0x3C50 0x3C50 commented Jun 6, 2023

No description provided.

@TheElectronWill
Copy link
Owner

Hi!
It would be good to add some tests to prevent a regression :)

@0x3C50
Copy link
Contributor Author

0x3C50 commented Jun 15, 2023

Hi!

It would be good to add some tests to prevent a regression :)

I've tested it with the existing "tests" already, it works just as intended. The existing tests aren't really tests tho, since no assertions are actually made, but looking at the output, it works just fine

@TheElectronWill
Copy link
Owner

The existing tests aren't really tests tho, since no assertions are actually made,

Oops, you're right, I'll blame my past self for that one.
I'll improve the tests in the future. Thank you for the PR!

@TheElectronWill TheElectronWill merged commit 90444f0 into TheElectronWill:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants