Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span Tag Inside of Links #28

Closed
sprankhub opened this issue Feb 8, 2016 · 1 comment · Fixed by #37
Closed

Add span Tag Inside of Links #28

sprankhub opened this issue Feb 8, 2016 · 1 comment · Fixed by #37
Assignees

Comments

@sprankhub
Copy link
Collaborator

It would be good if there was an additional span tag inside of the a tags. This would allow to hide the default text and replace it with an icon via CSS :before. For instance, here https://github.com/TheExtensionLab/MegaMenu/blob/master/app/design/frontend/base/default/template/theextensionlab/megamenu/page/html/topmenu/renderer.phtml#L22 replace:

<?php echo $this->escapeHtml($this->__($child->getName()))?>

with

<span><?php echo $this->escapeHtml($this->__($child->getName()))?></span>

This should be done in all default templates.

@JamesAnelay JamesAnelay self-assigned this Feb 9, 2016
@JamesAnelay
Copy link
Member

Thanks Simon this makes sense and seems to have no downside so I will implement this evening and aslong as it doesn't mess up the current css (I don't think it will).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants