Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate OpenAI & Anthropic plugins #38

Merged
merged 53 commits into from
May 21, 2024
Merged

Migrate OpenAI & Anthropic plugins #38

merged 53 commits into from
May 21, 2024

Conversation

Dabolus
Copy link
Collaborator

@Dabolus Dabolus commented May 21, 2024 •
edited
Loading

This PR migrates the more up-to-date OpenAI & Anthropic plugins from my repo so that from now on we can maintain them in this repo instead.

Note: due to the regeneration of the lockfile, the PR also bumps the Cohere AI package to version 7.10.0, which includes some breaking changes to the types. For this reason, a fix on the types of the Cohere plugin is also included in this PR.

Dabolus and others added 30 commits May 10, 2024 15:29
@Dabolus
feat: initial plugins implementation
6ca6ee0
@Dabolus
chore: bump packages
6393a02
@Dabolus
chore: remove unused root dependency
50ca475
@Dabolus
chore: move genkit packages to peer deps
4f02ca4
@MichaelDoyle @Dabolus
Enable system prompt on Dev UI
415421e
@Dabolus
chore: make imports more esm friendly
7484bf3
@Dabolus
chore: bump to v0.3.0
a8f84ad
@Dabolus
fix: missing esm import
ae358c3
@Dabolus
chore(anthropic): add system role support
0f7e1ce
@Dabolus
docs: update descriptions & examples to latest genkit version
20d55a6
@MichaelDoyle @Dabolus
Point to official genkit release 0.5.0
0651e52
@Dabolus
chore: bump to 0.4.0
67b3b5b
@Dabolus
docs: add security policy
86c0639
@Dabolus
docs: update issue templates
12e195b
@Dabolus
docs: add pull request template
9c1d327
@Dabolus
docs: be more specific about how to report a vulnerability
4eb5e5f
@Dabolus
docs: move pull request template to .github root
5a75836
@Dabolus
feat: add support for latest gpt4-turbo models
ed63089
@Dabolus
feat: add support for new gpt-4o model 🚀
c2e47e6
@Dabolus
chore: bump to 0.5.0
7f7ca4b
@Dabolus
test: add test cases for gpt-4o
eed391c
@Dabolus
chore: bump to 0.5.1
2f4c493
@Dabolus
chore(openai): bump sdk to fix typings issues
6cdefb8
@Dabolus
chore: bump to 0.5.2
d52d4ca
@Dabolus
chore: bump to 0.5.3
76309c3
@Dabolus
refactor: transfer ownership to firebase community
3f0138f
@Dabolus
feat(openai): add support for tts models
3285652
@Dabolus
fix: typos
a9485e6
@Dabolus
feat(openai): add support for whisper model
3ddd965
@Dabolus
docs(openai): update readme with new models + more examples
8fb29ce
EPMatt
EPMatt requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@EPMatt EPMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the merging. Added a couple of edits to perform before merging

SECURITY.md Outdated Show resolved Hide resolved
plugins/openai/package.json Outdated Show resolved Hide resolved
Dabolus and others added 2 commits May 21, 2024 18:51
EPMatt
EPMatt previously approved these changes May 21, 2024
View reviewed changes
@Dabolus Dabolus marked this pull request as ready for review May 21, 2024 17:17
@Dabolus Dabolus requested a review from EPMatt May 21, 2024 17:17
EPMatt
EPMatt previously approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@EPMatt EPMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine for the monorepo setup! @davidoort it would be great if you could review the changes to the ts source files in both plugins as you are more experienced with the plugins

davidoort
davidoort reviewed May 21, 2024
View reviewed changes
Copy link
Contributor

@davidoort davidoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @Dabolus !!!

Since you've been added to CODEOWNERS for Anthropic and OpenAI I guess you're not adding a note in the respective plugin readme's? We can always add it later and do it for all of them ofc

davidoort
davidoort previously approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@davidoort davidoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge on my side, if tests pass and basic E2E examples have been tested

@Dabolus
Copy link
Collaborator Author

Dabolus commented May 21, 2024

@davidoort yes, I'm ok with not adding the note at least for now since we have the CODEOWNERS, but let's see how things evolve in the future, we can always add the note later on (I'm also curious to know what other plugin authors/owners think about this)

@Dabolus Dabolus merged commit ea4e133 into main May 21, 2024
1 check passed
@Dabolus Dabolus deleted the feat/anthropic-openai branch May 21, 2024 19:20
@allcontributors allcontributors bot mentioned this pull request May 21, 2024
Closed
@TheFireCo TheFireCo deleted a comment from allcontributors bot May 21, 2024
@EPMatt
Copy link
Collaborator

EPMatt commented May 21, 2024

Thanks for the great contribution @Dabolus! @all-contributors please add @Dabolus as a docs and test contributor as well.

@allcontributors allcontributors bot mentioned this pull request May 21, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@EPMatt

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Dabolus! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidoort davidoort davidoort approved these changes

@EPMatt EPMatt EPMatt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dabolus @EPMatt @davidoort @MichaelDoyle