Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "length" or "offset" parameter from command completion methods #35

Closed
TheFriendlyCoder opened this issue May 1, 2018 · 0 comments
Assignees
Milestone

Comments

@TheFriendlyCoder
Copy link
Owner

Currently the Friendly Shell APIs force completion methods to have 3 mandatory parameters: a list of parsed parameters, and index number for the parameter to be populated, and a length/offset value within the token where the cursor was located. This model was a reflection of other APIs like the built in cmd class, but honestly I can't see a good reason to keep it in our APIs here. I propose removing this seemingly superfluous parameter to simplify the calling code.

@TheFriendlyCoder TheFriendlyCoder self-assigned this May 2, 2018
TheFriendlyCoder added a commit that referenced this issue May 2, 2018
Fixes #35 Removed superfluous offset parameter from completion methods
@TheFriendlyCoder TheFriendlyCoder added this to the 1.0.0 milestone May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant