Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREW-724: SGttEH: Heresy of Steel #2167

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

revilowaldow
Copy link
Contributor

@revilowaldow revilowaldow commented Jul 5, 2024

image

  • Images & Maps
  • Game Master's Primer
  • The Cursed Convoy
    • Adventure Text
    • mapRegions
    • foundrySceneRoot
  • In the Belly of the Beast
    • Adventure Text
    • mapRegions
    • foundrySceneRoot
  • Appendix
  • License

@revilowaldow
Copy link
Contributor Author

So this failed (expected) on referencing homebrew-img assets in a different source folder.
There's going to be some brews that share assets.
Suggestion for this is something akin to this in the _meta:

"dependencies": {
	"imgRepo": [
		"SGttEH"
	]
}

@TheGiddyLimit
Copy link
Owner

before I go making changes, does the stupid work?

can you symlink a file and have it show up in raw. ...?

@revilowaldow
Copy link
Contributor Author

You mean individually symlink the images across dirs?
That doesn't feel at all approachable to the lay user.
And while this file only has 3 errors had I chosen to split out e.g. Steinhardt's Player Options book I'd be doing hundreds of individual links.

@revilowaldow
Copy link
Contributor Author

Also no, you get a link file
image

@TheGiddyLimit
Copy link
Owner

fair enough; tested a relative symlink and it didn't work either

@TheGiddyLimit
Copy link
Owner

didn't much like sticking it in _meta as it's purely a static-testing thing, so: https://github.com/TheGiddyLimit/5etools-utils/blob/master/schema-template/homebrew.json#L300

"_test": {
  "additionalImageSources": [ "SGttEH" ]
}

likely going to be a few bugs with adding another "_meta-like" prop but those will all come out in the wash

@revilowaldow
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants