Separate Trailing Comma Array and Hash Literal #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeWilliams
approved these changes
Mar 5, 2018
Rubocop 0.53.0 created two new cops for controlling trailing comma style preferences for arrays and hashes which may be found here: rubocop/rubocop#5307. This removes the `Style/TrailingCommaInLiteral` cop in favor of these more granular cops. As a result of this change, gnar-style needs to be updated to use the new cops and remove the use of the old one. This updates to use the new cops and updates the gemspec to reflect that this now requires 0.53 of rubocop in this version to adhere to the available cops.
kevin-j-m
force-pushed
the
trailing-comma-cop
branch
from
aa1343b
to
303a903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop 0.53.0 created two new cops for controlling trailing comma style
preferences for arrays and hashes which may be found here:
rubocop/rubocop#5307.
This removes the
Style/TrailingCommaInLiteralcop in favor of thesemore granular cops.
As a result of this change, gnar-style needs to be updated to use the
new cops and remove the use of the old one. This updates to use the new
cops and updates the gemspec to reflect that this now requires 0.53 of
rubocop in this version to adhere to the available cops.