Support for TrueNAS SCALE

[hans00]

Known bug:

• Version string parse error

PVE::Storage::LunCmd::FreeNAS::freenas_api_check : successful : Server version: TrueNAS-SCALE-20.08-MASTER-20200824-142916
Argument "test-iscsi" isn't numeric in sprintf at /usr/share/perl5/PVE/Storage/LunCmd/FreeNAS.pm line 403.

• SCST doesn't allow character '/'

FATAL: Device 'storage/vm-222-disk-0' configured for handler 'vdisk_blockio' may not contain character '/'.

[TheGrandWazoo]

@hans00 - Thank you for your pull request. I will need to test these changes against FreeNAS and TrueNAS-Core before I place them into the mainstream code.

[TheGrandWazoo]

@hans00 - I am assuming the SCST is the new iSCSI initiator used in TrueNAS Scale?

[hans00]

Yes the TrueNAS Scale use SCST.

[aanon4]

I notice this tweak for SCALE is different in the current code. I'm bumping into an issue where I try to use a pool called "tank/vm" rather than just "tank". It works fine but I have to go in and fix the extent name because it ends up with a / in it. This original fix handled that case while the current fix doesn't. Everything works fine once the name has been fixed.

[TheGrandWazoo]

@aanon4 - Could you provide some output of the issue. Syslog should pickup the error so I can see what needs to be fixed.

[hans00]

It may bug on this line
https://github.com/TheGrandWazoo/freenas-proxmox/blob/master/perl5/PVE/Storage/LunCmd/FreeNAS.pm#L513

Will trigger SCST configure error if the pool name contains slash.
It should patch the pool name also.

[TheGrandWazoo]

It may bug on this line
https://github.com/TheGrandWazoo/freenas-proxmox/blob/master/perl5/PVE/Storage/LunCmd/FreeNAS.pm#L513

Will trigger SCST configure error if the pool name contains slash.
It should patch the pool name also.

$name  = $scfg->{'pool'} . ($product_name eq "TrueNAS-SCALE" ? '-' : '/') . $name;

So you're saying that $scfg->{'pool'} needs to have any '/' (slashes) turned into a '-' (dash)?
Do $name need it also?

I guess I better spin up a TrueNAS Scale VM for testing.

[hans00]

In PVE case, $name not need convert.
But $scfg->{'pool'} should convert.

The actual configuration check:
https://github.com/openunix/scst/blob/a85ae9e6a110299e62b1f0ca4df58a2d470dc184/scstadmin/scstadmin.sysfs/scstadmin#L2071

Not allow slash unless starts with /dev/.

[TheGrandWazoo]

@hans00 - Thanks for your help on this. I'll get a fix going plus I will spin up a SCALE VM for testing.

[aanon4]

@hans00 thanks for jumping on this for me! Just circling back to this today and you've done all my work for me - much appreciated. Fantastic software @TheGrandWazoo, let me know if I need to add and/or test anything for you.

[TheGrandWazoo]

Fix has been committed for Beta testing.

[aanon4]

Fantastic - works a treat! Thank you.

[TheGrandWazoo]

Thank you for working with me to get a fix in place.

[TheGrandWazoo]

Closing due to fix in place.