Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra slash #488

Merged
merged 5 commits into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@garanews
Copy link
Contributor

commented May 30, 2019

it fixes #487
Thanks @csoc49 for reporting
Thanks @ssstonebraker for found fix

At the time analyzer was written that slash was needed :)

garanews added some commits May 30, 2019

remove extra slash
it fixes #487
re added slash for ip query
after a live check , the slash is needed for ip query

@jeromeleonard jeromeleonard self-assigned this May 30, 2019

@jeromeleonard jeromeleonard added this to the 2.1.0 milestone May 30, 2019

@jeromeleonard jeromeleonard changed the base branch from master to develop May 30, 2019

@jeromeleonard

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Currently reviewing. I don't have access to this service. I assume that this is due to a change of the URL to access to the service ? (It has now a trailing '/' that it hasn't before) ?

Also in the fix:

line 122 _session.get('%/sresolve/%s'

Could you confirm that it is _session.get('%sresolve/%s' instead ?

If yes I change it before merging.

added check to strip slash in the url
added check to strip slash in the url
@garanews

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

I just tested again and now every request need the slash... so the original code works!
I presume someone added url with slash at the end, going to strip it.

garanews added some commits May 31, 2019

update readme with testing
update readme with testing
@jeromeleonard

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

thx @garanews, that is what I supposed while reviewing the code. It is better like this.

@jeromeleonard jeromeleonard merged commit fac4838 into TheHive-Project:develop Jun 9, 2019

1 check failed

continuous-integration/drone/pr Build is failing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.