remove extra slash #488
Merged
remove extra slash #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it fixes TheHive-Project#487
after a live check , the slash is needed for ip query
jeromeleonard
added
scope:analyzer
|
Currently reviewing. I don't have access to this service. I assume that this is due to a change of the URL to access to the service ? (It has now a trailing '/' that it hasn't before) ? Also in the fix: line 122 Could you confirm that it is If yes I change it before merging. |
added check to strip slash in the url
|
I just tested again and now every request need the slash... so the original code works! |
update readme with testing
|
thx @garanews, that is what I supposed while reviewing the code. It is better like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it fixes #487
Thanks @csoc49 for reporting
Thanks @ssstonebraker for found fix
At the time analyzer was written that slash was needed :)