Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit for SendGrid responder #739

Merged

Conversation

colin-stubbs
Copy link
Contributor

Adds SendGrid responder to deliver email via SendGrid HTTPS API

@colin-stubbs
Copy link
Contributor Author

[FR] SendGrid based mail delivery via HTTPS API #738

@dadokkio
Copy link
Contributor

Hi @colin-stubbs , thanks for the pull.
It's working fine and, ignoring some comments in the code, is more or less ok to merge.

Regarding the question you have with thehive:alert support it was created for specific tasks like dataleak. Eg. if you have an alert that creates observable for each mail in a dataleak you could notifies all leaked internal user automatically.
So, probably, your changes that require mail observable starting with "mail:" is not 100% ok.

I've also merged today another pull related to Mailer that enables support for tasks description.

I don't know if you want to review your code or keep the initial release as is.
Probably everyone is going to change details on those responder depending on their necessity in any case.

@jeromeleonard jeromeleonard linked an issue Jun 14, 2020 that may be closed by this pull request
@jeromeleonard jeromeleonard added this to the 2.8.0 milestone Jun 14, 2020
@jeromeleonard jeromeleonard added the scope:analyzer Issue is analyzer related label Jun 14, 2020
@jeromeleonard jeromeleonard added this to In progress in Release 2.8.0 via automation Jun 14, 2020
@jeromeleonard
Copy link
Contributor

Hi @colin-stubbs,

I confirm what @dadokkio said. Mail responders in general can be used for many use cases and custom usages. Depending on incident types, you may store/find recipient email address in tags, CustomFields or observables.

@jeromeleonard jeromeleonard changed the base branch from develop to release/2.8.0 June 14, 2020 08:07
@jeromeleonard jeromeleonard merged commit 89b75b7 into TheHive-Project:release/2.8.0 Jun 14, 2020
Release 2.8.0 automation moved this from In progress to Done Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:analyzer Issue is analyzer related
Projects
No open projects
Release 2.8.0
  
Done
Development

Successfully merging this pull request may close these issues.

[FR] SendGrid based mail delivery via HTTPS API
3 participants