Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included privacy type setting for URL/File analysis #854

Merged
merged 2 commits into from Sep 18, 2020
Merged

Included privacy type setting for URL/File analysis #854

merged 2 commits into from Sep 18, 2020

Conversation

aacgood
Copy link

@aacgood aacgood commented Sep 14, 2020

Code to address FR: #853

@garanews garanews added the category:enhancement Issue is related to an existing feature to improve label Sep 14, 2020
garanews
garanews suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@garanews garanews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please keep version 1.0 this is not a big update and in this way no further templates and other actions are needed.

garanews
garanews approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@garanews garanews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

@garanews
Copy link
Contributor

Hi @aacgood with my tester license I was able to try private and bylink settings. both work like excpected.
I am sure that will work also public setting (but need hunter license)
image
image

@garanews garanews merged commit a56645d into TheHive-Project:develop Sep 18, 2020
@garanews garanews added this to In progress in Cortex-Neurons 3.0 via automation Oct 5, 2020
@garanews garanews moved this from In progress to Done in Cortex-Neurons 3.0 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garanews garanews garanews approved these changes

Assignees

@dadokkio dadokkio

@garanews garanews

Labels
category:enhancement Issue is related to an existing feature to improve
Projects
Cortex-Neurons 3.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aacgood @garanews @dadokkio