Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Tags and custom fields can be seen across organisations / potential for data leakage #1778

Closed
shortstack opened this issue Feb 4, 2021 · 9 comments
Assignees
Labels
question TheHive4 TheHive4 related issues
Milestone

Comments

@shortstack
Copy link

Request Type

Bug / Feature Request

Work Environment

Question Answer
OS version (server) Ubuntu 18.04
OS version (client) Mac
TheHive version / git hash 4.0.4-1
Package Type deb
Browser type & version Chrome

Problem Description

Users in other organisations can see custom fields and tags that have been used across organisations other than their own.

This causes the potential for data leakage between organisations. We may not be able to use the multi-tenancy features/add users until this is no longer an issue.

@shortstack shortstack added TheHive4 TheHive4 related issues bug labels Feb 4, 2021
@nadouani
Copy link
Contributor

nadouani commented Feb 5, 2021

What type of data is included as tags in your cases?

Custom fields definitions are in fact common to all organisations, but not their values.

@reconluke
Copy link

Our concern is that other organisations can create their own tags which leaves a potential for data being leaked especially since tags autocomplete. For example if organisation A puts an email address as a tag and organisation B starts typing in something with the same 3 starting letters they would be able to see that entire tag as an autocomplete option.

@shortstack
Copy link
Author

shortstack commented Feb 17, 2021

@nadouani any plans to populate these on a per organisation basis?

@nadouani
Copy link
Contributor

In TheHive 4.1, free tags are related to an organisation.

With that being said, we recommend to not use any sensitive data as a tag. Use custom fields instead

@nadouani
Copy link
Contributor

Our concern is that other organisations can create their own tags which leaves a potential for data being leaked especially since tags autocomplete. For example if organisation A puts an email address as a tag and organisation B starts typing in something with the same 3 starting letters they would be able to see that entire tag as an autocomplete option.

Autocomplete will behave differently in 4.1, and will suggest tags from your own organisation only.

@nadouani nadouani added this to the 4.1.0 milestone Feb 22, 2021
@nadouani nadouani added enhancement and removed bug labels Feb 22, 2021
@shortstack
Copy link
Author

@nadouani any idea when 4.1.0 will be released? between this and the slowness/performance issues, wondering what kind of time frame we're looking at

@nadouani
Copy link
Contributor

4.1 is almost there, it has been paused to fix the ES 7.11 breaking changes on TheHive 3 and Cortex.
4.1 should be out in few days

@nadouani
Copy link
Contributor

nadouani commented Mar 4, 2021

Tag auto complete is now just returning the freetags defined within the current organisation.

@nadouani nadouani closed this as completed Mar 4, 2021
@nadouani nadouani changed the title [Bug] Tags and custom fields can be seen across organisations / potential for data leakage [Question] Tags and custom fields can be seen across organisations / potential for data leakage Mar 6, 2021
@shortstack
Copy link
Author

thank you!! @nadouani any ETA on 4.1 release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

4 participants