Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxMind Analyzer 'Short Report' has hard-coded language #23

Closed
ecapuano opened this issue Nov 22, 2016 · 2 comments
Closed

MaxMind Analyzer 'Short Report' has hard-coded language #23

ecapuano opened this issue Nov 22, 2016 · 2 comments
Assignees
Milestone

Comments

@ecapuano
Copy link

ecapuano commented Nov 22, 2016

Request Type

Bug? (but not really?)

Work Environment

Any

Problem Description

When running MaxMind analyzer, the short report returns the result in French, because the report code has fr hard coded.
https://github.com/CERT-BDF/TheHive/blob/master/analyzers/MaxMind/report/success_short.html#L1

Steps to Reproduce

  1. Run MaxMind analyzer, observe short report in French.

Possible Solutions

Perhaps require initial configuration of user locale in /etc/thehive/application.conf and import that locale code wherever needed, such as on MaxMind short report at TheHive/analyzers/MaxMind/report/success_short.html

Complementary information

N/A

@nadouani nadouani added the bug label Nov 22, 2016
@nadouani nadouani self-assigned this Nov 22, 2016
@nadouani nadouani added enhancement and removed bug labels Nov 22, 2016
@nadouani
Copy link
Contributor

Thanks @ecapuano the template is in fact displaying the country and city in French. We will update that and display the result based on the browser's locale. Note that Maxmind doesn't support all the languages, so we will default to english if the user's language is not supported.

@nadouani
Copy link
Contributor

After a discussion, and since TheHive supports only english language and is not yet ready for i18n, we will display the maxmind location in english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants