Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using asterisks by tag-filtering #933

Closed
crackytsi opened this issue Mar 19, 2019 · 5 comments
Closed

Support for using asterisks by tag-filtering #933

crackytsi opened this issue Mar 19, 2019 · 5 comments
Assignees
Labels
enhancement TheHive4 TheHive4 related issues
Milestone

Comments

@crackytsi
Copy link

Request Type

Feature Request

Work Environment

Question Answer
OS version (server) Debian
OS version (client) Seven
TheHive version / git hash 3.3.0-1
Package Type RPM, DEB, Docker, Binary, From source
Browser type & version Chrome

Problem Description

The Case #666 adds general support for using the "*" as asterisk.
First of all, thanks for introducing this feature :) :) :)
It works fine e.g. for title or username etc.

Unforunately this does not work with Tags. That means not in the case-list and also not in the dashboard (e.g. using a donut and filter anyof tags "category:*").

As this technically was working with my ES tests, I assume that it is not correctly translated.

Another related issue is that autocompletion suggests you something and it requires 2 times pressing escape not to accept this suggestion.
I would expect if I type something that autocompletion suggests I select the entry from the suggestions or just press enter to accept that what I had typed in. This is currently not the case.

Possible Solutions

-Translate the query also for tags on Cases / Observables.
-Use the typed in entry if no suggested autocompletion value is selected.

Complementary information

How to reproduce:

  1. Create a case with a tag, e.g. "category: demo"
  2. Add Filter for Tags: "category:*"
  3. Expected is only the case that has this tag.
@nadouani
Copy link
Contributor

No the changes made by #666 have been rolled back because it broke other filters. Now wildcard are supported but not by default, we have to enable them on some fields.

@nadouani nadouani self-assigned this Mar 26, 2019
@nadouani nadouani added this to the 3.4.0-RC1 milestone Mar 26, 2019
@nadouani nadouani removed this from the 3.5.0-RC1 milestone May 29, 2020
@crackytsi
Copy link
Author

@nadouani Is there any chance to get this implemented? Would really help a log (also for dashboards)

@crackytsi
Copy link
Author

@nadouani : I double checked it with TheHive 4.0.4 (at pre-blog time) but there it is also not working. Do you think you replan this as a TheHive4 feature in the future?
Right now its tagged for TheHive3 and I can't change that.

@nadouani nadouani added TheHive4 TheHive4 related issues and removed TheHive3 labels Feb 5, 2021
@nadouani nadouani added this to the 4.0.5 milestone Feb 5, 2021
nadouani added a commit that referenced this issue Feb 5, 2021
@nadouani
Copy link
Contributor

nadouani commented Feb 5, 2021

Tag filters now uses a like operator to allow the *XXXX* syntax on tag filters

@nadouani nadouani closed this as completed Feb 5, 2021
@crackytsi
Copy link
Author

@nadouani You made my day ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

2 participants