Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Quark compatability #15

Closed
DSchougaard opened this issue May 16, 2021 · 3 comments
Closed

[Suggestion] Quark compatability #15

DSchougaard opened this issue May 16, 2021 · 3 comments
Assignees
Labels
type: enhancement New feature or request

Comments

@DSchougaard
Copy link

Hello

Would it be possible to make the enchant appliable to the Pickarang from the Quark mod?

@TheIllusiveC4 TheIllusiveC4 self-assigned this May 16, 2021
@TheIllusiveC4 TheIllusiveC4 added the type: enhancement New feature or request label May 16, 2021
@DSchougaard
Copy link
Author

For what it's worth, a Pickarang can be spawned in with the enchantment using commands and it appears to be working as expected.

Command:
/give @p quark:pickarang{Enchantments:[{id:"veinmining:vein_mining",lvl:1}]} 1

@TheIllusiveC4
Copy link
Member

Yeah, looking at the source code for the Pickarang, I believe everything should work fine. I just need to make it a valid item for the enchantment. Possibly as a config option for additional valid items.

@Guernica520
Copy link

I would also love this feature to be added to the pickerang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants