Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement of basic package #27

Closed
5 tasks done
TheKaVu opened this issue May 22, 2023 · 0 comments · Fixed by #37
Closed
5 tasks done

Improvement of basic package #27

TheKaVu opened this issue May 22, 2023 · 0 comments · Fixed by #37
Assignees
@TheKaVu
Labels
enhancement New feature or request improvement It needs some improvement and extra features refactor This has to be changed

Comments

@TheKaVu
Copy link
Owner

TheKaVu commented May 22, 2023 •
edited

All the contents of .game package, especially GameManager class should be improved with addtition of some new features
@TheKaVu TheKaVu added enhancement New feature or request improvement It needs some improvement and extra features refactor This has to be changed labels May 22, 2023
@TheKaVu TheKaVu self-assigned this May 22, 2023
TheKaVu added a commit that referenced this issue May 22, 2023
@TheKaVu
Changed GameManager form generic of T to not generic (#27)
d7541be
TheKaVu added a commit that referenced this issue May 22, 2023
@TheKaVu
Made GameState abstract functions not abstract (#27)
cf76d42
TheKaVu added a commit that referenced this issue May 22, 2023
@TheKaVu
Added property storage to GameType (#27)
a01f0e7
@TheKaVu TheKaVu changed the title Improve the contents of .game package Improvement of .game package May 23, 2023
@TheKaVu TheKaVu changed the title Improvement of .game package Improvement of basic package May 24, 2023
TheKaVu added a commit that referenced this issue May 24, 2023
@TheKaVu
Added GameStateTimer.plugin field (#27)
c9211e6
TheKaVu added a commit that referenced this issue May 24, 2023
@TheKaVu
Changed uses of GameStateTimer constructor to match the new one (#27)
721bce7
TheKaVu added a commit that referenced this issue May 24, 2023
@TheKaVu
Fixed GameStateTimer.terminate function to call current state .onEnd …
1ce8ce0 
…method and call GameStateEndEvent (#27)
TheKaVu added a commit that referenced this issue May 26, 2023
@TheKaVu
Renamed GameTimerSchedule.java to GstSchedule.java (#27)
1f2fede
TheKaVu added a commit that referenced this issue May 26, 2023
@TheKaVu
Fixed to match renamed GstSchedule.java (#27)
5c36134
TheKaVu added a commit that referenced this issue May 26, 2023
@TheKaVu
Renamed GameTimerScheduleEndEvent.java to GstScheduleEndEvent.java (#27)
f0d527e
TheKaVu added a commit that referenced this issue May 26, 2023
@TheKaVu
Fixed to match renamed GstScheduleEndEvent.java (#27)
93f3176
TheKaVu added a commit that referenced this issue May 27, 2023
@TheKaVu
Made GameStateTimer.terminate not pause the timer (#27)
3d20752
TheKaVu added a commit that referenced this issue May 27, 2023
@TheKaVu
Made GameStateTimer.terminate not pause the timer (#27)
20d0c8e
TheKaVu added a commit that referenced this issue May 27, 2023
@TheKaVu
Added new parametrized condition check to ConditionalListener (#27)
b243cfb
TheKaVu added a commit that referenced this issue May 27, 2023
@TheKaVu
Fixed GameStateTimer state ato canceling (#27)
95a9358
TheKaVu added a commit that referenced this issue May 27, 2023
@TheKaVu
Fixed GameStateTimer state auto canceling (#27)
7aeb1ed
TheKaVu added a commit that referenced this issue May 28, 2023
@TheKaVu
Made Rule serializable (#27)
7dc3948
@TheKaVu TheKaVu closed this as completed May 28, 2023
@TheKaVu TheKaVu linked a pull request May 28, 2023 that will close this issue
Improvement/game package #37
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheKaVu TheKaVu

Labels
enhancement New feature or request improvement It needs some improvement and extra features refactor This has to be changed
Projects
@TheKaVu GameAPI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement/game-package TheKaVu/GameAPI
Improvement/game package TheKaVu/GameAPI
1 participant
@TheKaVu