Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Area and AreaController class improvement #39

Closed
Tracked by #32
TheKaVu opened this issue May 30, 2023 · 0 comments · Fixed by #47
Closed
Tracked by #32

Area and AreaController class improvement #39

TheKaVu opened this issue May 30, 2023 · 0 comments · Fixed by #47
Assignees
@TheKaVu
Labels
improvement It needs some improvement and extra features refactor This has to be changed

Comments

@TheKaVu
Copy link
Owner

TheKaVu commented May 30, 2023

No description provided.

@TheKaVu TheKaVu mentioned this issue May 30, 2023
Closed
5 tasks
@TheKaVu TheKaVu added improvement It needs some improvement and extra features refactor This has to be changed labels May 30, 2023
@TheKaVu TheKaVu self-assigned this May 30, 2023
TheKaVu added a commit that referenced this issue May 30, 2023
@TheKaVu
Moved inner Area.Target enum to new separate AffectTarget class (#39)
11e4ae8
TheKaVu added a commit that referenced this issue Jun 5, 2023
@TheKaVu
Removed Area.onEnter and Area.onLeave methods (#39)
5bab540
TheKaVu added a commit that referenced this issue Jun 5, 2023
@TheKaVu
Removed Border.java (#39)
5668519
TheKaVu added a commit that referenced this issue Jun 5, 2023
@TheKaVu
Renamed BorderShape.java to AreaShape.java (#39)
356774a
TheKaVu added a commit that referenced this issue Jun 5, 2023
@TheKaVu
Added border features to Area (#39)
9e454c5
TheKaVu added a commit that referenced this issue Jun 5, 2023
@TheKaVu
Fixed AreaController to match remade Area class. Removed 3 out of 4 l…
223339d 
…isteners (#39)
@TheKaVu TheKaVu changed the title Area class improvement Area and AreaController class improvement Jun 6, 2023
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Made AreaController.getPlayerArea and AreaController.getLocationArea …
515b36f 
…overload of AreaController.getArea function (#39)
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Added AreaController.getAreas function (#39)
892f7ba
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Removed unnecessary imports (#39)
678bcc7
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Changed AreaController.getAreas return type from Set to HashSet (#39)
59261a4
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Made Area abstract (#39)
bce8b96
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Added Area.onEnter and Area.onLeave abstract functions (#39)
7fe3909
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Added Area.onMove abstract function (#39)
c584ad9
TheKaVu added a commit that referenced this issue Jun 6, 2023
@TheKaVu
Added Area enter, move and leave calls (#39)
0859970
TheKaVu added a commit that referenced this issue Jun 8, 2023
@TheKaVu
Changed Area center from Location to Supplier of Location (#39)
7ef7a7a
TheKaVu added a commit that referenced this issue Jun 11, 2023
@TheKaVu
Fixed incorrect area size assignment (#39)
771cc15
TheKaVu added a commit that referenced this issue Jun 11, 2023
@TheKaVu
Renamed AreaControllerListener to AreaMoveListener (#39)
5202695
@TheKaVu TheKaVu closed this as completed Jun 11, 2023
@TheKaVu TheKaVu linked a pull request Jun 11, 2023 that will close this issue
Improvement/world package #47
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheKaVu TheKaVu

Labels
improvement It needs some improvement and extra features refactor This has to be changed
Projects
@TheKaVu GameAPI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvement/world-package TheKaVu/GameAPI
Improvement/world package TheKaVu/GameAPI
1 participant
@TheKaVu