Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ClutterActor's expand/align properties #22

Merged
merged 1 commit into from
May 25, 2022

Conversation

squall77it
Copy link

BoxLayout meta child (expand/align) properties have long been depracated and recently fully removed in gnome shell 3.37.2 (!1274), in favor of ClutterActor's ones.

Embrace the change to provide compatibility with upcoming gnome shell 3.38 release

BoxLayout meta child (expand/align) properties have long been depracated and recently fully removed in gnome shell 3.37.2 (!1274), in favor of ClutterActor's ones.

Embrace the change to provide compatibility with upcoming gnome shell 3.38 release
@rastersoft
Copy link

With this, and updating the metadata.json file, it also works with Gnome Shell 40.

rastersoft pushed a commit to rastersoft/gnome-shell-extension-transmission-daemon that referenced this pull request Sep 12, 2021
Added the patch by squall77it

TheKevJames#22

which adds compatibility with Gnome Shell 3.38. Also added "40"
in metadata.json.
@joenepraat
Copy link

@squall77it @rastersoft I successfully replaced this extension.js and modified metadata.json to make it work with Gnome 42. Is there maybe a possibility this can officially be forked and published on the official Gnome extensions site? Because a lot of people are not that technical.

@joenepraat
Copy link

I have to warn that it gives problem on Gnome 42 (at least on Ubuntu 22.04). I have had system crash and according my syslog it was after errors of this extension in the same log file.

…
May 19 17:39:20 myhost gnome-shell[1808]: cr_parser_new_from_buf: assertion 'a_buf && a_len' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_declaration_parse_list_from_buf: assertion 'parser' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_parser_new_from_buf: assertion 'a_buf && a_len' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_declaration_parse_list_from_buf: assertion 'parser' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_parser_new_from_buf: assertion 'a_buf && a_len' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_declaration_parse_list_from_buf: assertion 'parser' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_parser_new_from_buf: assertion 'a_buf && a_len' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_declaration_parse_list_from_buf: assertion 'parser' failed
May 19 17:39:20 myhost gnome-shell[1808]: Could not create transient scope for PID 21837: GDBus.Error:org.freedesktop.DBus.Error.UnixProcessIdUnknown: Process with ID 21837 does not exist.
May 19 17:39:20 myhost gnome-shell[1808]: Could not create transient scope for PID 21838: GDBus.Error:org.freedesktop.DBus.Error.UnixProcessIdUnknown: Process with ID 21838 does not exist.
May 19 17:39:20 myhost gnome-shell[1808]: Could not create transient scope for PID 21839: GDBus.Error:org.freedesktop.DBus.Error.UnixProcessIdUnknown: Process with ID 21839 does not exist.
May 19 17:39:20 myhost gnome-shell[1808]: cr_parser_new_from_buf: assertion 'a_buf && a_len' failed
May 19 17:39:20 myhost gnome-shell[1808]: cr_declaration_parse_list_from_buf: assertion 'parser' failed
May 19 17:39:22 myhost gnome-shell[1808]: JS ERROR: TypeError: transmissionDaemonIndicator is null#012processSession@/home/joene/.local/share/gnome-shell/extensions/transmission-daemon@patapon.info/extension.js:342:9

@TheKevJames
Copy link
Owner

Sorry for my incredibly long delay on noticing this one.

I don't currently have a gnome box to test this on, but happy to handle publishing and all that. Am I correct in assuming this PR would change the supported shell versions to 38, 40, and 42? /cc @joenepraat @squall77it If that's the case, happy to merge & publish accordingly.

@joenepraat
Copy link

@TheKevJames I don't think this should be used on Gnome 42. It gave those errors I pasted above, plus I remember that the settings dialog didn't work either.

@TheKevJames
Copy link
Owner

Gotcha, thanks for confirming. Alright, I'll get this up targeting 38&40, and then we'll see about getting v42 supported separately.

@TheKevJames TheKevJames merged commit 958fb9b into TheKevJames:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants