Updates to ZPM #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed extensions ui.
…for the most part
…ite and delete configfs files. Created api to download files. Added a handler that fires once after configuration loads.
…stall extension command to installed extensions page. Changed how updating works to try to make it less likely that an extension breaks during a failed update. If you're in the configuration project when installing, updating or uninstalling an extension the filelist now reloads
Conflicts: app/config/api/zed/config_fs.js app/config/api/zed/http.js app/config/api/zed/project.js app/js/sandbox.js
removing it when uninstalling.
|
Btw, it may look like I rewrote everything, this is no the case ;) I did switch over the plugins to CommonJS style (removed AMD junk), which is the diff is a bit skewed. |
|
Awesome, this works great! Very excited about this...it's so cool. |
allie-wake-up
pushed a commit
that referenced
this pull request
Apr 11, 2014
Updating to the latest master
allie-wake-up
pushed a commit
that referenced
this pull request
Jan 29, 2015
node-webkit changed it's name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok this is kind of a big PR with many unrelated commits which will go away once you merge zed/master into your TheKiteEathingTree/zpm branch. The commits that are relevant to see what I did here:
Basically I implemented what I mentioned in zedapp#90:
packageskey, whenever you add stuff to this, the URI in question (more on URIs later) will be installed and once installed, will be loaded.gh:username/repo:branch, orgh:username/repo(master is implicit),bb:username/repoorbb:username/repo:branchwhich would all be expanded to their HTTPS equivalentsThings that I changed along the way:
/packages)package.jsonno longer need aconfigFilekey (config.jsonis assumed), this is for practical reasons, but it also has the advantage of requiring less options inpackage.jsonpackage.jsonno longer requires anidkey, since "pathified" versions of the URIs are used (colons are replaced with a slash).As a demo, I moved out the spell checker into its own package: https://github.com/zedapp/spellchecker you can install it either the interactive way, or by adding
"gh:zedapp/spellchecker"to yourpackageskey inuser.json, watchzed::logfor messages.I've also tested it by putting a (previously) not installed package in
/zedconfig.jsonand it successfully installs the package and loads it only in that project and not others.What do you think?