Add note to README to update workflow triggers #128
Conversation
This was an oversight on my part that I would suspect others might run into - I used the template and pushed to a main branch, and totally missed the fact that none of the workflows were running. When it was time to properly add tests I realized that the files were there, and I simply needed to update the branch from master to main. So that others don't run into this issue, I am suggesting adding a line in the README to alert the reader to do the change.
|
Good point, I started working on this template when the default branch name was still As an alternative to the workflow note, how would you feel about simply adding triggers for both |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Yes that's a great idea! Done. |
.github/workflows/style.yml
Outdated
| - main | ||
|
|
There was a problem hiding this comment.
Small formatting nitpick, but could you remove the extra new line from here and the ubuntu and windows workflows, to make them consistent with the others?
There was a problem hiding this comment.
Thanks, the newline is still in the style.yml workflow commented above, as far as I can tell.
There was a problem hiding this comment.
That's embarrassing! My editor didn't save the file (err, I didn't seem to hit save 😆) - should be good now :)
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Thank you for the template! I'm a bit green to C++ and I was able to get started with my project so quickly thanks to this. |
This was an oversight on my part that I would suspect others might run into - I used the template and pushed to a main branch, and totally missed the fact that none of the workflows were running. When it was time to properly add tests I realized that the files were there, and I simply needed to update the branch from master to main. So that others don't run into this issue, I am suggesting adding a line in the README to alert the reader to do the change.