Add CMake Workflow Presets to simplify usage #161
Conversation
| name: Install | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - main | ||
| - develop |
There was a problem hiding this comment.
We have master and main as these are two common defaults for new Git projects. develop on the other hand is more specific and users might want to define specific CI rules for such a branch, which is why it shouldn't be in the template IMO.
There was a problem hiding this comment.
I use git flow, that is also common used and has develop
There was a problem hiding this comment.
And that's fine, but in the starter I'd prefer a single style for simplicity instead of mixing different approaches.
ClausKlein
force-pushed
the
feature/use-project-options
branch
2 times, most recently
from
b28eac1
to
e0e6ff7
Compare
There was a problem hiding this comment.
Thanks for the PR. Tbh I don't think it makes sense to go forward with this as it now goes far beyond updating packages used. The starter is not intended to suit every workflow but present an simple and opinionated starting point for new projects that users can adapt to suit their needs.
Perhaps instead we can reference to your fork of the starter to show more advanced configurations?
update CPM.cmake version too Set FORCE option for SOURCE_DIR usage
link alias target cxxopts::cxxopts
export cxx_std_20 with target_compile_features() but do not export pedantic Waning options!
ClausKlein
force-pushed
the
feature/use-project-options
branch
from
93b53a4
to
fe240db
Compare
ClausKlein
changed the title
ClausKlein
force-pushed
the
feature/use-project-options
branch
from
31eab5f
to
bb30af2
Compare
- Upgrade to gitup workflow action v3 - Prepare use of git-flow - Use CMake v3.21 variable PROJECT_IS_TOP_LEVEL - Use CMAKE_DEBUG_POSTFIX to prevent name clashes - Add more config files
ClausKlein
force-pushed
the
feature/use-project-options
branch
from
bb30af2
to
d81a424
Compare
|
I am not longer interested to help! |
And add
CMake Workflow Presetsto simplify usage