Fix problems while using local installed packages #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClausKlein
changed the title
|
@TheLartians Would you like to review this MR? |
TheLartians
reviewed
Aug 19, 2023
There was a problem hiding this comment.
If I understand correctly, these changes are required when using this package with CPM_USE_LOCAL_PACKAGES defined, right?
Tbh I'm conflicted on these changes as it adds some complexity to the starter for a rather niche use case. IMO instead it could make sense mentioning in the Readme that the starter does not support this mode out of the box as it isn't recommended for CPM anyways as it has known issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update CPM.cmake version too
This should fix this issue #176