Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice message instead of exception when no photos #134

Closed
preppietechie opened this issue Dec 17, 2022 · 10 comments
Closed

Nice message instead of exception when no photos #134

preppietechie opened this issue Dec 17, 2022 · 10 comments

Comments

@preppietechie
Copy link

I've got the contents of my google photos takeout zip files extracted to c:\user\username\desktop\photos-decompress\Takeout\GooglePhotos\ (so it's a big folder full of dated subfolders which, in turn contain the images and json files).

Running v3.0, It appears that it can't find any contents of the specified folder, and I get the following error:

C:\Users\Username\Downloads> gpth-v3.0.0-Windows.exe -i C:\users\Username\Desktop\photos-decompress\Takeout\GooglePhotos\ -o C:\users\Username\Desktop\photos-decompress\cu
WARNING: Script will move files from input to output - not copy

  • this is faster, and doesn't use extra space, but will break your
    input folder (it will be, well, empty)
    If you want copy instead of move, exit script (ctrl-c) and use --copy flag
    Otherwise, press enter to agree with that

Okay, running... searching for everything in input folder...
Found 0 photos/videos in input folder
Unhandled exception:
Unsupported operation: Infinity or NaN toInt
#0 FillingBar._render (package:console_bars/src/filling_bar.dart)
#1 new FillingBar (package:console_bars/src/filling_bar.dart:73)
#2 main (file:///d:/a/googlephotostakeouthelper/googlephotostakeouthelper/bin/gpth.dart:220)

C:\Users\username\Downloads>

@preppietechie
Copy link
Author

It also does the same thing if I specify c:\users\username\Desktop\photos-decompress\Takeout\

@TheLastGimbus
Copy link
Owner

huh, weird... do you have "year folders" in your takeout? folders named like "Photos from 2016" ? or just albums

@preppietechie
Copy link
Author

just the albums... folders like:

C:\Users\username\Desktop\photos-decompress\Takeout\Google Photos\1-27-12
and
C:\Users\username\Desktop\photos-decompress\Takeout\Google Photos\2013 San Francisco\

with photos and json files inside them.

@TheLastGimbus
Copy link
Owner

Okay then - new script takes all photos only from year folders, and looks up at albums only to link the information about them (which it currently does nothing with, see #135)

If you can, just take the new export from google and select only "photos from ..." folders

Otherwise, best option is to use old python version

Is there some particular reason you have this like that? I may change the behavior of current code if there is...

@TheLastGimbus TheLastGimbus changed the title Unhandled Exception Nice message instead of exception when no photos Dec 19, 2022
@preppietechie
Copy link
Author

preppietechie commented Dec 20, 2022 via email

@TheLastGimbus
Copy link
Owner

Okay so... when you took your takeout, you selected all the folders, and that's just the way yours is?

@KM192
Copy link

KM192 commented Dec 31, 2022

I have the same issue. My case is that I would like to take from Google only photos from albums, while they are well organized by me. I do not care or even do not want to take all pictures from whole years. is there a chance that program would take pictures from all albums and would re-create album structure in the output folder ?

@TheLastGimbus
Copy link
Owner

@KM192 Yeah, i think this will be main "album impementation". See #135 discussion for that

Looks like I will have to change behaviour of photo-finding... created #140 for that

@llliax
Copy link

llliax commented Jan 5, 2023

For a long time I could not understand why all my photos did not want to be converted. Please add in bold to the instructions that the photos should be at the root of the year folder. Then the transfer happens. The transfer is lightning fast! Thank you for your work!

@TheLastGimbus
Copy link
Owner

For now, gpth just prints a nice message. I won't implement "Albums only" mode because it would complicate stuff very much.

@llliax there is now interactive mode which exports the zips for you, leaving no place for user error (other than wrongly selecting zips) - hope this fixes your problem 😁 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants