New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON naming too long? #8
Comments
Ummm, I'm not sure what you mean by this, but no - finding corresponding json fails because names don't match (eg |
Hi I would like to reopen this issue. I have checked that google photos JSON files are limited to 51 characters including the |
Ooohh... this interesting... yet another way from Google to make it harder 🔥 If you could send here exaples of that happening (happens exactly for 51 chars, all the time)? This is so absurd that I could even try to upload new Photos, myself with special super long name, take another takeout and see if it does that 😆 If so, yeah, PR would be very welcome 🙃 - you just need to modify |
Okay, I did more research and it seems to be a total mess. So, out of a total of 50874 json files in my dataset, 2382 json files had a length of exactly 51 characters. But there's more. I checked the pictures related to these files and they also have a length of 51 characters meaning that the filename of the picture also got truncated. See this example:
So they truncate everything > 51 because why not? (WTF google?) To make matters worse, I found 4 pictures and their JSONs with a file name of 54. So it seems that they truncate but there are some weird exceptions 🤷♂️ . So, checking the title field will only help for pictures where the file name is between 46 and 51 characters. Which is not much but it's something |
Hm..I wonder what the likelihood of collisions are for just matching the first 50 characters though. I would imagine it should ideally follow some convention that would make it unique. @jmigual would you mind verifying if there are and images that match multiple json files if you use 50 characters? |
Sorry, I don't think I follow. Do you mean checking if multiple images can match the title field in the JSON file? |
Idea: we could just load every json in folder and check for the name inside the tags - not by json's file name. It would theoretically be less efficient, but would be much more successful |
This is not what I meant but I think that's a better idea and what @TheLastGimbus is alluding to. If the json file has the full name then that's what we should use. |
Has anyone reported this to google, because this is surely not desired behaviour? |
Google doesn't care. You can try to write some email to them, but you will probably get some typical, corporate, waffle response: "Sorry Sir, our Takeout service doesn't plan any on any changes in it's behavior" You know, this whole repo is because of "not desired behaviour"... |
That's a shame... |
Okay, so I wrote a post on Google Support: https://support.google.com/accounts/thread/88318924 But this service seems to be "community support" - nothing where actuall Google employees look at... But we will see 👍 You guys can give it a +1 to make it more visible... |
Upvoted |
This should be solved in new beta - try it out and report if there are any issues - if not, I'll release it as official:
|
I have several JSON files which names are probably too long. for exmple:
this way your script does not found the json files?
The text was updated successfully, but these errors were encountered: