Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geo data #5

Merged
merged 11 commits into from
Nov 29, 2020
Merged

Geo data #5

merged 11 commits into from
Nov 29, 2020

Conversation

DalenW
Copy link
Contributor

@DalenW DalenW commented Nov 26, 2020

Adds the ability to add geo data automatically from googles JSON, and it will skip it if it is empty.

Holy frick this was annoying.

TheLastGimbus
TheLastGimbus requested changes Nov 27, 2020
View reviewed changes
Copy link
Owner

@TheLastGimbus TheLastGimbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, clean, commented code, and I'm really thankful that you were motivated enough to mess with this - exifs are just nightmare 😖

Some small changes and will be good to go 👍

google_photos_takeout_helper/__main__.py Outdated Show resolved Hide resolved
google_photos_takeout_helper/__main__.py Outdated Show resolved Hide resolved
@DalenW
Copy link
Contributor Author

DalenW commented Nov 28, 2020

Should be fixed now. I added a fallback to the GeoDataExif if the GeoData was empty just in case.

@TheLastGimbus
Copy link
Owner

When I wrote the suggestion code block, you can just click on "commit" button and it will apply my suggestion - but it's nice that you've added comments

TheLastGimbus
TheLastGimbus requested changes Nov 28, 2020
View reviewed changes
Copy link
Owner

@TheLastGimbus TheLastGimbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't check every single value - choose either form geoData or exif (unless you have some strong argument against it)

google_photos_takeout_helper/__main__.py Outdated Show resolved Hide resolved
@DalenW @TheLastGimbus
Cleaner geoData fetch.
82e15fe 
Co-authored-by: Mateusz Soszyński <mateusz.soszynski@tuta.io>
TheLastGimbus
TheLastGimbus approved these changes Nov 29, 2020
View reviewed changes
Copy link
Owner

@TheLastGimbus TheLastGimbus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks and works fine - wonder how many issues it's gonna cause for other people, if just setting correct date did

Maybe some people have lat: 123124324235643543253453253425 lng: -new_york 😆

@TheLastGimbus TheLastGimbus merged commit 3610242 into TheLastGimbus:master Nov 29, 2020
@TheLastGimbus
Copy link
Owner

Thank you once again for making this ❤️

@DalenW DalenW deleted the GeoData branch November 30, 2020 23:11
@TheLastGimbus TheLastGimbus mentioned this pull request Oct 13, 2021
Closed
@TheLastGimbus TheLastGimbus mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheLastGimbus TheLastGimbus TheLastGimbus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DalenW @TheLastGimbus