Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion doesn't work with recent versions of git. #321

Closed
dseomn opened this issue Feb 3, 2021 · 1 comment
Closed

bash completion doesn't work with recent versions of git. #321

dseomn opened this issue Feb 3, 2021 · 1 comment
Assignees
Labels
Projects

Comments

@dseomn
Copy link
Contributor

dseomn commented Feb 3, 2021

It looks like

# only operate if git completion is present
if declare -F _git > /dev/null; then
checks for a _git function, but git/git@441ecda removed that function from git's bash completion. I'm guessing that the replacement is either __git_main or __git_wrap__git_main, but I'm not sure.

@dseomn dseomn added the bug label Feb 3, 2021
@TheLocehiliosan TheLocehiliosan self-assigned this Feb 7, 2021
@TheLocehiliosan TheLocehiliosan added this to To do in 3.1.0 via automation Feb 7, 2021
@TheLocehiliosan
Copy link
Owner

This is a duplicate of #318, follow that issue for resolution.

3.1.0 automation moved this from To do to Done Feb 7, 2021
TheLocehiliosan added a commit that referenced this issue Mar 22, 2021
* Use `git clone` directly during clone (#289, #323)
* Fix compatibility bug with Git completions (#318, #321)
* Support relative paths for --yadm-* and -w (#301)
* Improve parsing of if-statement in default template (#303)
* Read files without running cat in subshells (#317)
* Improve portability of updating read-only files (#320)
* Various code improvements (#306, #307, #311)
TheLocehiliosan added a commit that referenced this issue Apr 3, 2021
* Use `git clone` directly during clone (#289, #323)
* Fix compatibility bug with Git completions (#318, #321)
* Support relative paths for --yadm-* and -w (#301)
* Improve parsing of if-statement in default template (#303)
* Read files without running cat in subshells (#317)
* Improve portability of updating read-only files (#320)
* Various code improvements (#306, #307, #311)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
3.1.0
  
Done
Development

No branches or pull requests

2 participants