Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Service Type variable #19

Merged
merged 2 commits into from Sep 13, 2021
Merged

Make Service Type variable #19

merged 2 commits into from Sep 13, 2021

Conversation

joe-ERhz5pn0
Copy link
Contributor

@joe-ERhz5pn0 joe-ERhz5pn0 commented Sep 8, 2021

Currently the used service type is oneshot. This is a good choice for most.

However, I came across an issue that I need systemd to restart the service on failure. This sadly is not possible with oneshot, but it is with simple.

Anyhow, I would be happy if you could merge this and create a new tag. Thanks!

@puppet-community-rangefinder
Copy link

systemd_cron is a type

that may have no external impact to Forge modules.

This module is declared in 0 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@TheMeier TheMeier self-assigned this Sep 13, 2021
@TheMeier
Copy link
Owner

@joe-ERhz5pn0 you need to add the type variable to the epp() call in manifests/init.pp

You can run the tests locally with pdk test unit. I will re-add automatic testing when I have some time for it

@joe-ERhz5pn0
Copy link
Contributor Author

@joe-ERhz5pn0 you need to add the type variable to the epp() call in manifests/init.pp

You can run the tests locally with pdk test unit. I will re-add automatic testing when I have some time for it

Apologies, added.

@TheMeier TheMeier merged commit 76ffd0d into TheMeier:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants