Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paella: Add missing blob: libarcsoft_panorama_burstcapture.so #7

Closed
wants to merge 6 commits into from
Closed

Conversation

stucki
Copy link

@stucki stucki commented Oct 3, 2016

Copied from piccolo

Kra1o5 and others added 6 commits September 10, 2016 21:50
vegetalte: initial blob import
1.3 based blobs + build time_genoff

Change-Id: I536d9af629957907270193ef38298b2b4bba13be
piccolo: Updates from 4.2.1 release
@marado
Copy link
Collaborator

marado commented Oct 3, 2016

This isn't used on paella (check here), and bq seems to use it only for bq's camera, which we don't ship on CM.
In other words, this blob seems to be unnecessary for CM/paella.

@stucki
Copy link
Author

stucki commented Oct 3, 2016

The situation is 1:1 the same for piccolo. There is an (unofficial) zip available which adds the BQ camera to CyanogenMod. It is known to work for Paella too if this file is added here.

If you think it's wrong then we should probably delete the file from piccolo and vegetalte too (and add it to the BQ camera zip file instead).

You can find CameraBQ_signed_v4.1.0.zip at https://s.basketbuild.com/devs/eloimuns/bq/piccolo/

@marado
Copy link
Collaborator

marado commented Oct 3, 2016

Oh, I see.
Well, yes, if this is a blob that is needed for an app, and that app is distributed on a .zip, I'd guess the proper place for the blob to be would be in the zip.

@stucki
Copy link
Author

stucki commented Oct 3, 2016

I will check this. I'm not sure why the files are shipped for piccolo and vegetalte. If there's any other reason other than this camera zip file, then it will most likely be the same situation for paella.
If not, then I agree, the file can be removed from all three device trees (and be moved into the camera zip file).

Will leave this open until we have clarified it...

@stucki
Copy link
Author

stucki commented Apr 11, 2017

No longer needed (the file has been merged during the switch from paella to picmt codebase).

@stucki stucki closed this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants