fix(react): use default values correctly

niledatabase · Jan 25, 2023 · d020b40 · d020b40 · vercel · Jan 25, 2023
1 parent 4f4f7ee
commit d020b40
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/packages/react/src/lib/SimpleForm/index.tsx b/packages/react/src/lib/SimpleForm/index.tsx
@@ -28,7 +28,7 @@ export const getAttributeDefault = (
       return [String(attribute.defaultValue)];
     }
   }
-  return '';
+  return attribute.defaultValue ?? '';
 };
 
 export default function ConfigForm(props: {

diff --git a/packages/react/stories/EntityForm.stories.tsx b/packages/react/stories/EntityForm.stories.tsx
@@ -37,6 +37,7 @@ const customFieldAttributes = [
     name: 'environment',
     label: 'Environment',
     type: AttributeType.Select,
+    defaultValue: 'test',
     options: [
       { label: 'Test', value: 'test' },
       { label: 'Development', value: 'dev' },

diff --git a/packages/react/test/lib/SimpleForm/index.tsx b/packages/react/test/lib/SimpleForm/index.tsx
@@ -10,4 +10,12 @@ describe('simple form', () => {
     };
     expect(getAttributeDefault(attribute)).toEqual(['gcp']);
   });
+  it('maps default values for not a checkbox', () => {
+    const attribute: Attribute = {
+      name: 'cloud',
+      type: AttributeType.Select,
+      defaultValue: 'gcp',
+    };
+    expect(getAttributeDefault(attribute)).toEqual('gcp');
+  });
 });