Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: RSpec Part 1: The Basics #22519

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Feature: RSpec Part 1: The Basics #22519

merged 1 commit into from
Aug 19, 2021

Conversation

KevinMulhern
Copy link
Member

Because:

  • We are rewriting the testing section in the Ruby course and need to cover the basics of RSpec

This lesson covers:

  • Installing and setting up RSpec
  • Structuring test files with example groups
  • What expectations are
  • A few common matchers
  • The three typical phases of a test
  • The extra teardown phase which is sometimes needed

@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-one-basics-lesson branch from b1bb42d to 0009b76 Compare August 11, 2021 22:38
@KevinMulhern KevinMulhern mentioned this pull request Aug 11, 2021
Closed
5 tasks
@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-one-basics-lesson branch from 0009b76 to 1cac350 Compare August 12, 2021 07:57
CouchofTomato
CouchofTomato approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@CouchofTomato CouchofTomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mate this is awesome. Only a couple of comments but this is really well written and sets a great standard for the rest of the lessons.

ruby_programming/automated_testing/rspec_part_one_basics.md Outdated Show resolved Hide resolved
ruby_programming/automated_testing/rspec_part_one_basics.md Show resolved Hide resolved
@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-one-basics-lesson branch from 1cac350 to 2f0d4f0 Compare August 12, 2021 18:15
rlmoser99
rlmoser99 reviewed Aug 14, 2021
View reviewed changes
Copy link
Member

@rlmoser99 rlmoser99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW! This lesson is amazing and I really wish I had this lesson when I learned testing!

I have a few tiny nitpicks, but the lesson content is really laid out well and covers everything thoroughly! Great job! 👍

ruby_programming/automated_testing/rspec_part_one_basics.md Outdated Show resolved Hide resolved
ruby_programming/automated_testing/rspec_part_one_basics.md Outdated Show resolved Hide resolved
ruby_programming/automated_testing/rspec_part_one_basics.md Outdated Show resolved Hide resolved
ruby_programming/automated_testing/rspec_part_one_basics.md Outdated Show resolved Hide resolved
ruby_programming/automated_testing/rspec_part_one_basics.md Outdated Show resolved Hide resolved
@KevinMulhern
Feature: RSpec Part 1: The Basics
aa8a30a 
Because:
* We are rewriting the testing section in the Ruby course and need to cover the basics of RSpec

This commit:

This lesson covers:

* Installing and setting up RSpec
* Structuring test files with example groups
* What expectations are
* A few common matchers
* The three typical phases of a test
* The extra teardown phase which is sometimes needed
@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-one-basics-lesson branch from 3f61011 to aa8a30a Compare August 15, 2021 22:14
@KevinMulhern KevinMulhern merged commit 4f0e10a into main Aug 19, 2021
@KevinMulhern KevinMulhern deleted the feature/rspec-part-one-basics-lesson branch October 27, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CouchofTomato CouchofTomato CouchofTomato approved these changes

@rlmoser99 rlmoser99 rlmoser99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KevinMulhern @CouchofTomato @rlmoser99