Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: RSpec Part 2: Hooks, Let and Subject #22520

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Feature: RSpec Part 2: Hooks, Let and Subject #22520

merged 1 commit into from
Aug 19, 2021

Conversation

KevinMulhern
Copy link
Member

Because:

  • We are rewriting the testing lessons in the Ruby course and need a lesson to teach the student about coding sharing techniques in RSpec.

This lesson covers:

  • Before and after hooks
  • Let variables
  • Subject
  • Context groups

@KevinMulhern KevinMulhern mentioned this pull request Aug 11, 2021
Closed
5 tasks
@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-two-code-sharing-lesson branch from 563d164 to 233e348 Compare August 12, 2021 08:00
CouchofTomato
CouchofTomato approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@CouchofTomato CouchofTomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again mate. Awesome stuff.

ruby_programming/automated_testing/rspec_part_two_code_sharing.md Outdated Show resolved Hide resolved
ruby_programming/automated_testing/rspec_part_two_code_sharing.md Outdated Show resolved Hide resolved
@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-two-code-sharing-lesson branch from 233e348 to 0379974 Compare August 12, 2021 18:13
rlmoser99
rlmoser99 requested changes Aug 14, 2021
View reviewed changes
Copy link
Member

@rlmoser99 rlmoser99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another amazing job on this lesson! 🎉

Just found one thing as I was following along that you probably refactored at some point.

ruby_programming/automated_testing/rspec_part_two_code_sharing.md Outdated Show resolved Hide resolved
@KevinMulhern
Feature: RSpec Part 2: Hooks, Let and Subject
47cce43 
Because:
* We are rewriting the testing lessons in the Ruby course and need a lesson to teach the student about coding sharing techniques in RSpec.

This commit:

This lesson covers:
* Before and after hooks
* Let variables
* Subject
* Context groups
@KevinMulhern KevinMulhern force-pushed the feature/rspec-part-two-code-sharing-lesson branch from 0379974 to 47cce43 Compare August 15, 2021 22:13
@KevinMulhern KevinMulhern merged commit 3f63fde into main Aug 19, 2021
@KevinMulhern KevinMulhern deleted the feature/rspec-part-two-code-sharing-lesson branch October 27, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlmoser99 rlmoser99 rlmoser99 requested changes

@CouchofTomato CouchofTomato CouchofTomato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KevinMulhern @CouchofTomato @rlmoser99