Flexbox Alignment: Combine Practice section into Assignment section #23825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm-murphy
added
Type: Enhancement
thatblindgeye
approved these changes
Mar 18, 2022
Comment on lines
51
to
59
| 5. Go back to our [CSS exercises repository](https://github.com/TheOdinProject/css-exercises) (don't forget that the instructions are in the README). Do the exercises in the 'flex' directory in the following order: | ||
| * 01-flex-center | ||
| * 02-flex-header | ||
| * 03-flex-header-2 | ||
| * 04-flex-information | ||
| * 05-flex-modal | ||
| * 06-flex-layout | ||
| * 07-flex-layout-2 | ||
| * It may take you a while to get through all of them, and the difficulty ramps up as you progress. Stick with it! If you can get through all of them, then you will be in _really_ good shape moving forward. |
There was a problem hiding this comment.
Nitpick: do you think it might be better to take that last bullet out ("It may take...") and instead inline it with the numbered list item? E.g.:
5. ... Do the exercises listed below in the order that they are listed. It may take you a while....
Not overly fussed over it, but I'm thinking maybe if users might start the exercises without reading them all listed there and thus not seeing the last bullet item. Though this could be an issue that doesn't exist/isn't significant, so I leave it up to you; I'm good either way, so I'm approving it now regardless.
There was a problem hiding this comment.
I was debating taking off that last instruction item for a while but hadn't thought to just tack it into the number list item. I like it! I'll make the change.
thatblindgeye
approved these changes
Mar 18, 2022
This was referenced Jun 3, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the following REQUIRED checkboxes:
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textComplete the following checkboxes ONLY IF they are applicable to your PR. You can complete them later if they are not currently applicable:
1. Because:
Closes #XXXXX
This PR combines the existing Practice section into the Assignment section for the Alignment lesson in the Flexbox section of Foundations.
2. This PR:
3. Additional Information:
This PR is being used as a reference for combining the Practice sections into the Assignment section, as discussed on Discord with @thatblindgeye