Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "#react-router" link #24985

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

marcusicaro
Copy link
Contributor

@marcusicaro marcusicaro commented Dec 28, 2022

The second question on knowledge checks answer wasn't taking anywhere. So I fixed it pointing it towards where the answer is. (- How do you add page routing to a React project?)

Also, I've fixed a small typo on the same sentence.

Because

There's a small improvment to be done on the page.

This PR

  • Fixed the answer from the second question link not taking anywhere.
  • Fixed a small typo on the sentence where that link takes.

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The second question on knowledge checks answer wasn't taking anywhere. So I fixed it pointing it towards where the answer is.
(- <a class="knowledge-check-link" href="#react-router">How do you add page routing to a React project?</a>)

Also, I've fixed a small typo on the same sentence.
@github-actions github-actions bot added Content: JavaScript Involves the JavaScript course Status: Needs Triage labels Dec 28, 2022
@linkonsat
Copy link
Contributor

Thanks for making this fix!

@linkonsat linkonsat merged commit 30e2f4d into TheOdinProject:main Dec 29, 2022
@marcusicaro
Copy link
Contributor Author

Thanks for making this fix!

It's no bother.

Have a great day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: JavaScript Involves the JavaScript course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants