Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update express_102_crud_and_mvc.md #27935

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

SirGram
Copy link
Contributor

@SirGram SirGram commented May 6, 2024

fixed freecodecamp url

Because

fixed freecodecamp url

This PR

Issue

Closes #27934

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

fixed freecodecamp url
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label May 6, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Turns out the issue was really just a recent PR accidentally adding an extra 0 to the end of the link, which was missed in review. Still, the link has actually updated and the correct medium href just redirects to this new href anyway, so might as well link the current href now.

In the future, if you've opened an issue for something, please do not open a PR to close it unless you have been assigned the work by a maintainer, regardless of how complex the work is or isn't (as per our contributing guide). This is a standard practice for OSS contribution.

@MaoShizhong MaoShizhong merged commit a268ce4 into TheOdinProject:main May 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express 102: CRUD and MVC: Freecodecamp link not working
2 participants