-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setting_up_git.md #28251
Update setting_up_git.md #28251
Conversation
issue TheOdinProject#28215 In the "Setting Up Git" lesson (setting_up_git.md), added a note section to clearly differentiate macOS-specific commands from general setup instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have specific styling code for these types of note blocks. Just using >
is not the right way to do it in this situation.
Please review the style guide and update this PR accordingly before we can consider merging it.
https://github.com/TheOdinProject/curriculum/blob/main/LAYOUT_STYLE_GUIDE.md#note-boxes
- Replaced > quotes with <div> tags and added appropriate classes for note boxes. - Included markdown="1" attribute to ensure nested markdown is displayed properly.
Removed extra blank lines from setting_up_git.md that were inadvertently included in a previous commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theSamyak Thanks for working on the previous suggestions, just a couple of minor touches needed to get this ready to go.
Co-authored-by: Michael Frank <michael@mfrnk.nz>
Co-authored-by: Michael Frank <michael@mfrnk.nz>
Hi, I messed up my commit history and there is still some linting issue and I apologize for it. I have cloned the project into VS Code and from now on, will make the changes and contributions from there to maintain a cleaner commit history and preserve my sanity. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
issue #28215
In the "Setting Up Git" lesson (setting_up_git.md), added a note section to clearly differentiate macOS-specific commands from general setup instructions.
Because
Added a note section in the "Setting Up Git" lesson to clearly differentiate macOS-specific commands from general setup instructions.
This PR
Added a note section in setting_up_git.md to highlight macOS-specific commands and also changed the title "macOS Users" to "For macOS Users" improving clarity for users.
Issue
Closes #28215
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section