Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS exercises README: change shortcuts to kbd format #367

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

ManonLef
Copy link
Member

@ManonLef ManonLef commented Jul 1, 2023

Because

We recently updated the style-guide to use <kbd> element formatting on keyboard shortcuts. There was one shortcut to be updated in this readme.

This PR

  • convert keyboard shortcut to correct styling for this repo's readme

Issue

Related to #25715

Additional Information

  • I have ignored other style issues PR dedicated to the keyboard shortcuts

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Copy link
Member

@xandora xandora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ManonLef ManonLef merged commit 5a7cd9b into TheOdinProject:main Jul 2, 2023
@ManonLef ManonLef deleted the kbd branch July 2, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants