Update sumAll-solution.js swap algorithm to standard method #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the swapping algorithm to the standard way of swapping using array restructuring.
cats256
changed the title
cats256
changed the title
Comment on lines
4
to
5
| if (min > max) { | ||
| const temp = min; | ||
| min = max; | ||
| max = temp; | ||
| } | ||
| if (min > max) [min, max] = [max, min]; | ||
|
|
There was a problem hiding this comment.
Not entirely sure if we should use this as the TOP solution, just because I don't believe it's something introduced to users at the point they're asked to do this exercise (believe it's the lesson they're first introduced to arrays).
Maybe we could add a comment that shows this method as an alternative.
thatblindgeye
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
I believe this way of swapping the values between variables in JavaScript is better for learners to know about since it is more common and reinforces understanding on array destructuring
This PR
Change the swapping algorithm to the standard way of swapping in JavaScript using array restructuring. Edit: Change for loop condition as well to the standard way
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesectionsolutionsbranch, I have created another PR (and linked it to this PR).