Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10_fibonacci: Update README.md #383

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

RushilJalal
Copy link
Contributor

Because

Added a wiki page to Fibonacci sequence

This PR

  • Adds wiki link to Fibonacci sequence
  • Changes layout slightly

Issue

Closes #381

Additional Information

This is the 2nd PR by me on the same issue. Please refer to #382

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

ManonLef
ManonLef previously approved these changes Jul 31, 2023
10_fibonacci/README.md Outdated Show resolved Hide resolved
Co-authored-by: Manon <81025586+ManonLef@users.noreply.github.com>
@ManonLef
Copy link
Member

ManonLef commented Aug 1, 2023

@RushilJalal thanks for the update. Instead of dismissing a review, you can re-request a review from the one asking for changes.

Screenshot 2023-08-01 at 14 24 25

@ManonLef ManonLef self-requested a review August 1, 2023 12:24
@ManonLef
Copy link
Member

ManonLef commented Aug 1, 2023

I will merge this. I was considering wrapping the link in an embed but that probably makes less sense since this Readme will probably be opened from inside VSCode where it will only lead to clutter unless watching it in preview mode.

@ManonLef ManonLef merged commit dd9a830 into TheOdinProject:main Aug 1, 2023
@RushilJalal
Copy link
Contributor Author

RushilJalal commented Aug 2, 2023

@RushilJalal thanks for the update. Instead of dismissing a review, you can re-request a review from the one asking for changes.

I'm sorry but I think I clicked on commit suggestion as you asked and it showed me the review is dismissed.

hhofent added a commit to hhofent/javascript-exercises that referenced this pull request Aug 15, 2023
hhofent added a commit to hhofent/javascript-exercises that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants