-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Foundations Resume button doesn't work as intended #3230
Comments
Thanks for taking the time to report this. However it isn't a bug, this is the intended behaviour. That button is really only an indicator for what path the user is correctly on when they are viewing all paths. But I can see how the "resume" wording can be confusing. We're planning on moving path selection to the paths themselves as part of this story - #3094. That will allow us to remove these buttons and use a different way to show the users current path. |
Then why does the Resume button in the Dashboard page takes you to the current working lesson and this one doesn’t? It seems to me that both buttons are intended to do the same thing. Also why have a View button next to it that takes you to the same page as the Resume button? I'm not sure if I completely understood you or if I didn't describe the bug correctly. |
Somebody asked about the same thing on Discord on recently - https://discord.com/channels/505093832157691914/997169784955342890/997179166594179112
#3094 is going to be how we tackle it, that will allow us to remove the "Resume" and "Select" buttons on the path cards. Edit: I think some confusion is coming from foundations only having one course. When your on a full stack path that has multiple courses, this is what it looks like on the dashboard: Potentially multiple resume buttons for the different courses. |
I see. Thanks for the clarification. |
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. --> ## Because <!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. --> A user might get confused about the current behavior of the "Resume" button in [All Paths](https://www.theodinproject.com/paths) (#3230, #4495). ## This PR <!-- A bullet point list of one or more items describing the specific changes. --> Helps to differentiate a selected path from the rest by: - Adding a "Selected" badge to the currently selected path. - Keeping only one "Continue" button instead of "Resume" and "View" buttons to selected path. **Note:** User needs to be logged in. #### Before (Foundations path selected) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/b0251b6f-fa08-45e3-9a22-b78d7fe2c79e) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/fb3460ce-d909-485f-9d70-66b2a8f11770) #### After (Foundations path selected) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/882a002d-730b-463e-99dd-53b92aff6b9e) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/3fc8be70-e5eb-42f7-8a53-c898f9903e34) #### Before (Ruby on Rails path selected) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/f1bee462-53c5-4d00-8576-5171da3b595e) #### After (Ruby on Rails path selected) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/8367b998-f2ba-427f-a0f6-711c2d9f2b61) #### Before (Javascript path selected) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/fe341e54-5149-4872-97a3-3515b5a64e00) #### After (Javascript path selected) ![image](https://github.com/TheOdinProject/theodinproject/assets/52906616/f15d043a-1ef5-4685-9c40-3e512e78fad6) ## Issue <!-- If this PR closes an open issue in this repo, replace the XXXXX below with the issue number, e.g. Closes #2013. If this PR closes an open issue in another TOP repo, replace the #XXXXX with the URL of the issue, e.g. Closes https://github.com/TheOdinProject/curriculum/issues/XXXXX If this PR does not close, but is related to another issue or PR, you can link it as above without the 'Closes' keyword, e.g. 'Related to #2013'. --> Closes #4495 ## Pull Request Requirements <!-- Replace the whitespace between the square brackets with an 'x', e.g. [x]. After you create the PR, they will become checkboxes that you can click on. --> - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [x] I have verified all tests and linters pass after making these changes. - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [x] If applicable, this PR includes new or updated automated tests --------- Co-authored-by: Josh Smith <jmsmith1018@gmail.com>
Complete the following REQUIRED checkboxes:
Bug: brief description of bug
format, e.g.Bug: Lesson complete button does not update on click
The following checkbox is OPTIONAL:
1. Description of the Bug:
Foundations Resume button in All Paths takes you to the Foundations Path page and not to the currently working lesson as intended.
2. How To Reproduce:
3. Expected Behavior:
4. Desktop/Device:
The text was updated successfully, but these errors were encountered: